Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Readme to C# 7.x syntax #906

Merged
merged 4 commits into from
May 15, 2020
Merged

docs: Update Readme to C# 7.x syntax #906

merged 4 commits into from
May 15, 2020

Conversation

aevitas
Copy link
Contributor

@aevitas aevitas commented Jul 5, 2019 •
edited
Loading

Fixes #895

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Update the readme example code to properly support asynchronous code

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 5, 2019
eshanholtz
eshanholtz reviewed Apr 14, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
eshanholtz
eshanholtz reviewed Apr 14, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@childish-sambino childish-sambino changed the title Update Readme to C# 7.x syntax docs: Update Readme to C# 7.x syntax May 15, 2020
@childish-sambino childish-sambino merged commit 22d9430 into sendgrid:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readme Quick Start section is using outdated syntax
4 participants
@aevitas @eshanholtz @childish-sambino @thinkingserious